Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0][IMP] website_snippet_carousel_product: Initialize animations #414

Conversation

Tardo
Copy link
Member

@Tardo Tardo commented Jul 23, 2020

Because the qweb is rendered asynchronously on the server side, we need force animations initialization to get the product card buttons worked (basically this PR ensure that animations that works over "oe_website_sale" class are initialized).
Improved the README too. Now offers an a domain example and an explanation that why we need use javascript syntax to define the domains.

cc @Tecnativa

@pedrobaeza pedrobaeza added this to the 12.0 milestone Jul 23, 2020
@pedrobaeza pedrobaeza requested a review from yajo July 23, 2020 16:20
@pedrobaeza
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 12.0-ocabot-merge-pr-414-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 13161c9 into OCA:12.0 Jul 24, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 7a7ff8e. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants